Vlc player enhancements

eliranwong / UniqueBible

A cross-platform bible application, integrated with high-quality resources and amazing features, running offline in Windows, macOS and Linux, ChromeOS, Android, iOS. Various running modes are supported.

https://UniqueBible.app

GNU General Public License v3.0

122 stars 34 forks source link

Vlc player enhancements #1338

Closed onegladiator4u closed 1 year ago

onegladiator4u commented 1 year ago

[x] Can you make the player to remember the volume level too. It keeps going full after restart.
[x] An option to hide player GUI from toolbar if there is not. I couldn't find it.. You could add it on Bible -> Toggle features or under a new menu like View.
[x] If we open two Bibles versions , one on main window and another on Study window. Only Main window Bible version audio will play for both when clicking on the audio icon. Hope you consider these suggestions.

eliranwong commented 1 year ago

[ ] Can you make the player to remember the volume level too. It keeps going full after restart.

can do

[x] An option to hide player GUI from toolbar if there is not. I couldn't find it.. You could add it on Bible -> Toggle features or under a new menu like View.

Already done.

Master control > Media Player > Audio

You can also move to the second toolbar, which can save space

[ ] If we open two Bibles versions , one on main window and another on Study window. Only Main window Bible version audio will play for both when clicking on the audio icon.

I don't understand this

onegladiator4u commented 1 year ago

@eliranwong

eliranwong commented 1 year ago

@eliranwong

did you install NKJV audio? I don't think we provide that due to copyright issues.

I mainly work on verse-by-verse audio. @otseng may know more about chapter audio.

eliranwong commented 1 year ago

bty, I added saving audio volume feature in the latest code https://github.com/eliranwong/UniqueBible/commit/9f87fd40d3fc25b5a735163da8c9aba338c35348

eliranwong commented 1 year ago

I think your third point is irrelevant. UBA cannot play audio that have not been installed.

otseng commented 1 year ago

It's designed to only play the audio of the main Bible, not the study Bible. @onegladiator4u what do you think if I just delete the icon from the study window to avoid confusion?

onegladiator4u commented 1 year ago

@eliranwong

did you install NKJV audio? I don't think we provide that due to copyright issues.

I mainly work on verse-by-verse audio. @otseng may know more about chapter audio.

@eliranwong Yes, I have NKJV audio.

onegladiator4u commented 1 year ago

It's designed to only play the audio of the main Bible, not the study Bible. @onegladiator4u what do you think if I just delete the icon from the study window to avoid confusion?

@otseng Yes, that's a good solution . Hiding it from Study does the job.

eliranwong commented 1 year ago

@eliranwong

did you install NKJV audio? I don't think we provide that due to copyright issues. I mainly work on verse-by-verse audio. @otseng may know more about chapter audio.

@eliranwong Yes, I have NKJV audio.

may I ask where did you get it? just curious

onegladiator4u commented 1 year ago

@eliranwong

did you install NKJV audio? I don't think we provide that due to copyright issues. I mainly work on verse-by-verse audio. @otseng may know more about chapter audio.

@eliranwong Yes, I have NKJV audio.

may I ask where did you get it? just curious

@eliranwong I got it from this app. https://play.google.com/store/apps/details?id=com.futuresoft.wordofpromise.free I had a new testament version subscribed. So copied it to UBA and arranged it.

eliranwong commented 1 year ago

@otseng do you want to do something about it, regarding chapter audio? If no plan, I may close this issue?

otseng commented 1 year ago

@otseng do you want to do something about it, regarding chapter audio? If no plan, I may close this issue?

OK, I'll modify the code.