search

eliranwong / UniqueBible

A cross-platform bible application, integrated with high-quality resources and amazing features, running offline in Windows, macOS and Linux, ChromeOS, Android, iOS. Various running modes are supported.
https://UniqueBible.app
GNU General Public License v3.0
131 stars 36 forks source link

Verse audio icons #1347

Closed onegladiator4u closed 1 year ago

onegladiator4u commented 1 year ago

Hey brothers, There are 3 types of audio icons in a page when it has verse mp3s.

  1. All Verses Play Audio Icon
  2. Chapter audio icon
  3. Verse Audio Icon In Bible >Toggle features there's an option to show and hide 'Display Verse Audio Icons'. This hides audio icons including 'Chapter audio icon' too. Is this intentional ? But the toggle name says Verse icons.

python_fBFL0uP06f But it didn't hide All Verse Play Audio Icon as in second screenshot image

In my opinion, that toggle should hide/show All Verses Play Icon and Verse Audio Icon OR hide/show All audio icons by renaming it like Hide Verse Icons OR hide/show Verse Audio icons only. Hope this doesn't confuse you.

eliranwong commented 1 year ago

"Verse Audio Icons" mean audio icon for a single verse audio.

I saw your screenshot have two icons next to chapter title, I think one of the icons is to trigger chapter audio, which I do not use myself. the toggle hide/show feature currently affects only icons for single verse audio. It does not affect chapter audio or word audio icons.

This toggle feature mainly helps me when I copy verses, when I don't want to include the icons in my copied content.

onegladiator4u commented 1 year ago

"Verse Audio Icons" mean audio icon for a single verse audio.

I saw your screenshot have two icons next to chapter title, I think one of the icons is to trigger chapter audio, which I do not use myself. the toggle hide/show feature currently affects only icons for single verse audio. It does not affect chapter audio or word audio icons.

This toggle feature mainly helps me when I copy verses, when I don't want to include the icons in my copied content.

Ok. But chapter audio icon was affecting for me. That's why created the issue . Chapters audio is still missing after the update.

otseng commented 1 year ago

Chapters audio is still missing after the update.

The latest update should hide the chapter audio if the hide verse audio icons is disabled. Is the chapter audio icon not toggling for you?

onegladiator4u commented 1 year ago

@otseng Hey bro, Are you saying that if we toggle the hide verse audio icons all icon including verse and chapter icons will be hidden/shown?

otseng commented 1 year ago

@otseng Hey bro, Are you saying that if we toggle the hide verse audio icons all icon including verse and chapter icons will be hidden/shown?

Yes

onegladiator4u commented 1 year ago

Oh ok. Then the toggle should be named Hide Chapter and Verse Audio Icons than Hide verse audio icons right ? That's what confused me.