eliranwong / UniqueBible

A cross-platform bible application, integrated with high-quality resources and amazing features, running offline in Windows, macOS and Linux, ChromeOS, Android, iOS. Various running modes are supported.
https://UniqueBible.app
GNU General Public License v3.0
121 stars 34 forks source link

theWord OT and ONT Hebrew bibles are not importing in RTL #684

Closed darrelwright closed 2 years ago

darrelwright commented 2 years ago

I have Old Testament Text Direction: Right-to-left checked. I import Hebrew Westminster LC, WLC and WLC+ and they are imported LTR. Am I missing something?Here's 2 bibles to play with:

Hebrew Westminster LC.ot.zip

WLC+.ont.zip

darrelwright commented 2 years ago

When I look at the WLC it imported RTL perfectly (including the fonts!), but WLC+ (as an example) did not and it has font issues.

otseng commented 2 years ago

For RTL, I need to fix that, but all it's doing is modifying the config file to determine if it's displayed RTL. For the time being, add your Bible to the rtlTexts in config.py

rtlTexts = ['original',
 'MOB',
 'MAB',
 'MIB',
 'HWLC',
]

For the font issue, will need to play around with it.

darrelwright commented 2 years ago

On RTL that worked perfect. Thanks!

On 7/20/21 5:57 PM, Oliver Tseng wrote:

For RTL, all it's doing is modifying the config file to determine if it's displayed RTL. Add your Bible to the rtlTexts in config.py

|rtlTexts = ['original', 'MOB', 'MAB', 'MIB', 'HWLC', ] |

For the font issue, will need to play around with it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eliranwong/UniqueBible/issues/684#issuecomment-883803770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXXZXCJDAZ2DJIK5U5UMA3TYYLONANCNFSM5AWUPVRA.

darrelwright commented 2 years ago

the font issue is kinda interesting - there appears to be only 1 letter that has a problem (i.e., בְּרֵאשִׁ֖ית, and yet in BHS+(as an example) it displays properly (בְּרֵאשִׁית). In the bibles (such as BSB Interlinear OT and WLC+) it appears to be the accent on 4th letter from the right that causes the issue.

On 7/20/21 5:57 PM, Oliver Tseng wrote:

For RTL, all it's doing is modifying the config file to determine if it's displayed RTL. Add your Bible to the rtlTexts in config.py

|rtlTexts = ['original', 'MOB', 'MAB', 'MIB', 'HWLC', ] |

For the font issue, will need to play around with it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eliranwong/UniqueBible/issues/684#issuecomment-883803770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXXZXCJDAZ2DJIK5U5UMA3TYYLONANCNFSM5AWUPVRA.