elirasza / stylelint-stylistic

Plugin for endangered stylelint stylistic rules.
Other
64 stars 3 forks source link

add support to stylelint 16 bro #17

Open ghost opened 10 months ago

ghost commented 10 months ago

Please support stylelint 16.0.0, the big one

Now the code is in ESM instead of CommonJS

Very good

Stylelint team published docs to know how to migrate with ease.

No need to keep support to commons from now on.

Style lint 16 is not allowed in your package.json. remove this restriction to

silverwind commented 10 months ago

It's not compatible with v16 because it apparently still has some imports from stylelint left which changed in v16:

Error: Cannot find module 'node_modules/stylelint/lib/utils/isStandardSyntaxAtRule'
    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1181:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1169:15)
    at resolveExports (node:internal/modules/cjs/loader:591:14)
    at Module._findPath (node:internal/modules/cjs/loader:668:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1130:27)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (node_modules/stylelint-stylistic/dist/rules/at-rule-name-case/index.js:3:32)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
tagliala commented 10 months ago

Hi,

I've tried to start working on this, but there are several changes involved, as per https://stylelint.io/migration-guide/to-16/ and at the moment I cannot allocate the time needed

daniluk4000 commented 10 months ago

@elirasza will you have time to work on this or should community take the lead for this one?

elirasza commented 10 months ago

I think the community should take the lead. I have very few time lately, but I suggest you look into https://github.com/firefoxic/stylelint-codeguide. @firefoxic has contacted me, wants to unify both packages, and has already prepared his for stylelint 16 + ESM. I am thinking about deprecating stylelint-stylistic in favor of stylelint-codeguide.

Mouvedia commented 10 months ago

@firefoxic has contacted me, wants to unify both packages…

This would be great.

firefoxic commented 10 months ago

This would be great.

Already! https://www.npmjs.com/package/@stylistic/stylelint-plugin 🚀

Mouvedia commented 10 months ago

@firefoxic that's cool. Ill switch once stylelint-stylistic/stylelint-stylistic#9 is fixed.