callgraph: make pre-push target pass with newer pandas versions

elisa-tech / tsc

Coordination between ELISA working groups, and repository for documentation based deliverables.

57 stars 14 forks source link

callgraph: make pre-push target pass with newer pandas versions #74

Open henrirosten opened 1 year ago

henrirosten commented 1 year ago

Read all callgraph csv fields as strings to match queries also in cases where datatypes might not match
Fix warnings reported by newer pycodestyle versions
Fix build error with travis on python 3.7, reference: https://travis-ci.community/t/build-error-for-python-3-7-on-two-different-projects/12895

Signed-off-by: Henri Rosten henri.rosten@unikie.com

henrirosten commented 1 year ago

@bulwahn : I wanted to try using the callgraph tool in a personal project, but noticed the query_callgraph.py no longer worked with latest pandas version. Also, noticed some other issues with travis builds, which are now also fixed with this PR. I'm not sure if https://github.com/elisa-tech/workgroups is maintained anymore, or if you are the maintainer but in case you are, could we merge this PR to make the query_callgraph.py usable again and fix current CI issues.

pahmann commented 1 year ago

@henrirosten thanks for providing the patch. I will check with @bulwahn to give also his approval to have a 4 eyes review on your patch. I will also put the PR to the agenda of the TSC meeting next week. (Nov 30) to conclude on the patch.

Thanks for fixing the issues.