elisa-tech / wg-automotive-safety-app

GNU General Public License v2.0
2 stars 3 forks source link

Handling of incomplete read() operation. #1

Closed abiasci closed 1 year ago

abiasci commented 3 years ago

As described by man:

read() attempts to read up to count bytes from file descriptor fd into the buffer starting at buf.

So it is possible that you will receive, in a reading operation, less bytes that the ones you are requested. In order to complete the read() operation you have to perform a cycle to get all the requested bytes.

pahmann commented 1 year ago

@sudipm-mukherjee can we trigger a build in CI with this PR? Do I need to create a new meta-elisa branch, which greps this branch from the safety-app to confirm that it is still building? I guess it is a good check to see how we handle dependencies. ;)

sudipm-mukherjee commented 1 year ago

On Wed, 14 Dec 2022 at 09:50, Philipp Ahmann @.***> wrote:

@sudipm-mukherjee can we trigger a build in CI with this PR? Do I need to create a new meta-elisa branch, which greps this branch from the safety-app to confirm that it is still building? I guess it is a good check to see how we handle dependencies. ;)

You will need to fork meta-elisa or create a new branch and modify meta-elisa-demo/recipes-elisa/pipe-demo/pipe-demo.bb to point to the repo at https://github.com/abiasci/wg-automotive-safety-app and branch to control_pipe and SRCREV to eb75174f4e18d7f34628ec38d54cfc9a493426df and then modify meta-elisa-ci to point the TEST_REPO to this forked meta-elisa. If you want I can trigger this for you.

-- Regards Sudip

pahmann commented 1 year ago

Build triggered using CI with following job: https://gitlab.com/elisa-tech/meta-elisa-ci/-/jobs/3509035205 qemu boot tested and checked using this link: https://gitlab.com/elisa-tech/meta-elisa-ci/-/jobs/3508952057/artifacts/file/screenshot/screenshot_20221221_155059.jpeg

@sudipm-mukherjee If you would be so kind and cross check, that I did things properly, we can merge and close this PR.

sudipm-mukherjee commented 1 year ago

On Wed, 21 Dec 2022 at 15:55, Philipp Ahmann @.***> wrote:

Build triggered using CI with following job: https://gitlab.com/elisa-tech/meta-elisa-ci/-/jobs/3509035205 qemu boot tested and checked using this link: https://gitlab.com/elisa-tech/meta-elisa-ci/-/jobs/3508952057/artifacts/file/screenshot/screenshot_20221221_155059.jpeg

@sudipm-mukherjee https://github.com/sudipm-mukherjee If you would be so kind and cross check, that I did things properly, we can merge and close this PR.

That looks perfect.

-- Regards Sudip

pahmann commented 1 year ago

CI and test successful. Sudip confirmed proper execution. Safety app will be worked on and updated together with Architecture WG soon, which will result in further review and refinement. This PR can be merged.