search

elise-fernandez / Design-Skills-Project

Independent project to create portable light
0 stars 0 forks source link

Electronics/software review #7

Open elise-fernandez opened 6 years ago

elise-fernandez commented 6 years ago

I don't believe I have received any feedback

mlp6 commented 6 years ago

Sorry - missed schematic since it wasn't in the Electronics/ directory. Schematic generally looks good. Can consider replacing the diode + DC offset with a single Zener diode with the appropriate breakdown voltage. Resistors and caps need specific values.

General software logic looks good... would get a jump on the actual code.

brinnaebent commented 6 years ago

Need to change board size to match that of polygon pour. If this is a shield, consider putting components between header pins to reduce size of board. Connections look good.