search

elisemercury / Duplicate-Image-Finder

difPy - Python package for finding duplicate or similar images within folders
https://difpy.readthedocs.io
MIT License
449 stars 66 forks source link

V2.3 improvements #20

Closed elisemercury closed 2 years ago

elisemercury commented 2 years ago

Various updates & bug fixes to the code

Pomax commented 2 years ago

It looks like this wasn't fixed: I installed 2.3 today and ran it on a dir that also had different duplicate finder running, but it looks like it's still crashing, rather than just skipping over, files that get deleted during the run:

libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
Traceback (most recent call last):][9%]
  File "d:\temp\test.py", line 3, in <module>
    search = dif("_reviewed", show_progress=True)
  File "C:\Program Files\Python39\lib\site-packages\difPy\dif.py", line 53, in __init__
    result, lower_quality = dif._search_one_dir(directory_A,
  File "C:\Program Files\Python39\lib\site-packages\difPy\dif.py", line 117, in _search_one_dir
    high, low = dif._check_img_quality(directory_A, directory_A, filenames_A[count_A], filenames_A[count_B])
  File "C:\Program Files\Python39\lib\site-packages\difPy\dif.py", line 282, in _check_img_quality
    size_imgB = os.stat(dirB + imageB).st_size
FileNotFoundError: [WinError 2] The system cannot find the file specified: '_reviewed\\kc08jt06vv691.jpg'
elisemercury commented 2 years ago

Hi @Pomax, Thank you for noticing! Indeed, the bug was only fixed for the search between 2 directories, not for the one-dir search. The issue has now been fixed! All the best Elise