search

elisemercury / Duplicate-Image-Finder

difPy - Python package for finding duplicate or similar images within folders
https://difpy.readthedocs.io
MIT License
421 stars 65 forks source link

Same duplicate in different keys #42

Closed Fenho closed 1 year ago

Fenho commented 1 year ago

We have found that when you use dif within a folder of folders, there may be some unexpected behaviour. In our case, we have a pair of duplicates in one folder, and a third duplicate in another one. This makes it so result will output:

image

So an element that was detected as duplicate is being used later as a key. We do not know if this is bug or a feature, but it may be inconsistent with the behavior of not repeating duplicates in later keys. Still, for our use we can just use a set() as a workaround to ignore "duplicates of duplicates".

Nice work on the tool, it has helped us a lot with a nasty database. Thank you, have a nice day!

5m0RZ

elisemercury commented 1 year ago

Hi @Fenho, Thanks for noticing and opening the issue! This indeed is not supposed to be a feature and produces quite a bit of confusion in the output. I'll work on a fix in the new version of difPy. Thanks and all the best, Elise

elisemercury commented 1 year ago

Hi @Fenho, The issue you raised has now been fixed with version 2.4.5. Again, thanks a lot for your contribution! All the best, Elise

Fenho commented 1 year ago

Great! Thank you for addressing it 😁