search

elisemercury / Duplicate-Image-Finder

difPy - Python package for finding duplicate and similar images
https://difpy.readthedocs.io
MIT License
465 stars 67 forks source link

Fix issue parsing boolean CLI arguments #68

Closed UplandsDynamic closed 1 year ago

UplandsDynamic commented 1 year ago

This fixes an issue where boolean CLI arguments were not being correctly evaluated, which resulted in erroneous and undesired script behaviours. For example, when running the script via the CLI, passing False as the argument for -l 0r --logs would not prevent full logging from being printed to the output stats.

In a related issue, the type for the __fast_search argument was defined as a string str rather than a boolean.

elisemercury commented 1 year ago

Hi @UplandsDynamic,

Closing this pull request as it has been implemented with #69. :wink:

Again, thanks a lot!

Elise