search

elisescu / tty-share

Share your linux or osx terminal over the Internet.
https://tty-share.com/
MIT License
806 stars 87 forks source link

Support nerd fonts #15

Closed andys8 closed 3 years ago

andys8 commented 3 years ago

It would be nice, if nerd fonts could be supported. These are quite common, if people play with their setup.

image

I haven't looked into it, but maybe it's enough to include one of the fonts and configure xterm to use it.

andys8 commented 3 years ago

I noticed I created this issue not in https://github.com/elisescu/tty-server/issues/9 and is already worked on: https://github.com/elisescu/tty-server/pull/10/files

I experimented with xterm.js and Nerd Fonts. It will display glyphs.

image

      @font-face {
        font-family: "Fira Code Nerd Font";
        src: url("fira.ttf") format("truetype");
        font-variant-ligatures: none;
      }
        this.xterminal = new Terminal({
            ...
            fontFamily : "Fira Code Nerd Font"
        });
strazto commented 3 years ago

This actually got merged into https://github.com/elisescu/tty-server/pull/16 but didn't make it into the v2 overhaul / that consolidated the hosting into this project, and diminished the role of the corresponding external server to simply acting as a proxy.

Unfortunately, not all of the codebase was migrated across to this project, so the changes given by my PR didn't make it across to this repo yet.

I'll submit another PR soon