elisescu / tty-share

Share your linux or osx terminal over the Internet.
https://tty-share.com/
MIT License
806 stars 87 forks source link

Russian locale isn't working properly, invisible characters #20

Closed Meister1593 closed 3 years ago

Meister1593 commented 3 years ago

Issue: Writing russian locale (ru_RU.UTF-8) through browser terminal makes characters weird question marks at sharing computer end and invisible characters in browser client end. Also, there's issue with erasing bash prompt in remote tty (at sharing computer end), because i write invisible characters (most likely tty-share doesn't expect these characters to be not shown, so it counts them too)

System: Arch Linux with linux-lts 5.4.72-1 kernel Using xfce4-terminal 0.8.9.2-2 with tty-share 0.6.1 from AUR

Issue shown in gif bellow Peek 2020-10-30 10-23

elisescu commented 3 years ago

Could you try with the latest version and see if the issue is still there? I updated the xterm.js to a newer version and maybe they fixed that on their side. Tbh, I don't even know how to fix it I am sure it's possible, just my frontend skills are very very basic. But I hope to get some time one day to look into it, if the latest version still has the issue.

Meister1593 commented 3 years ago

I checked with latest available version (2.1.0) and it's indeed working now I can type Russian in both terminals and it will look fine on both sides. I guess this can be closed now

elisescu commented 3 years ago

Cool. Closing it then :)