search

elishacloud / Logging

This project supports logging. It is intended to be used for use as a submodule in other projects to reduce code redundancy.
Other
0 stars 0 forks source link

Improve hybrid graphics logging #1

Open mirh opened 10 months ago

mirh commented 10 months ago

It only shows which gpu has the primary display attached atm. And especially after https://github.com/elishacloud/dxwrapper/issues/159, it would be nice to detect which does the rendering and which does the presenting.

https://github.com/elishacloud/Logging/blob/1d648564323f5e68f6aa82330cb666ba6dfbf365/Logging.cpp#L588-L594

p.s. I would also recommend to check the Buffer1 and Buffer2 logic because I'm not really understanding its dual printing purpose

elishacloud commented 9 months ago

I actually added code to get the "real" adapter that is being used here. This code in the logger cannot get the real adapter being used because the adapter could be selected at a later point, which is why I added that other code.

In the dxwrapper log file you can see it like this:

2268 16:29:37.798 m_IDirect3D9Ex::LogAdapterNames Adapter: 0 \\.\DISPLAY1 NVIDIA GeForce GTX 1050

Having both the "default" adapter and the adapter that is actually being used in the log file is useful, I think.

As far as the the Buffer1 and Buffer2 logic, this is two different ways of getting the computer manufacturer from the BIOS. On some computers only one or the other works. If both works it will show up like the below:

Here is what it currently looks like:

2760 16:40:42.026 Dell Inc. XPS 15 9560 (Notebook)
2760 16:40:42.026 Dell Inc. 05FFDN A00 (Notebook)

Here is what it would look like if the buffers are combined into one:

10688 16:55:11.615 Dell Inc. XPS 15 9560 Dell Inc. 05FFDN A00 (Notebook)