search

elishacloud / Silent-Hill-2-Enhancements

A project designed to enhance Silent Hill 2 (SH2) graphics and audio for the PC. It also includes scripts to build or modify SH2 audio files (SFX, BGM and Dialog).
http://www.enhanced.townofsilenthill.com/SH2/
zlib License
539 stars 41 forks source link

Playtesters wanted for new SH2 PC audio engine #511

Closed Polymega closed 2 years ago

Polymega commented 2 years ago

Since day one of its launch, Silent Hill 2 PC has been plagued with an awful audio loop bug. As you play, the sounds in the game would inevitably begin to loop infinitely until the game became too unstable and crashed. The "fix" for 20 years has been to run the game on a single core, but this was never truly a fix as it was a band-aid to mask the problem that still exists beneath.

Fast forward to today and @Gemini-Loboto3 has completely rewrote the audio engine for SH2 PC so that the game can be played on multiple cores with stable audio! This is a monumental achievement for the game/our project and, as such, will benefit greatly from having many people playtest this to ensure everything is working as it should. As you can imagine, replacing the whole audio engine is nothing to sneeze at, so testing is paramount.

This is where you come in: We'd like to ask you to playtest the new audio engine build!

What to test for

Play the game to completion like normal, that's it! As you play, just make sure nothing odd is going on with the audio. We recommend you take your time playing. Go in every room you can think of to make as many sounds in the game play. Perhaps save your game progress and load back into it from time to time. Think of any way to stress test the audio for the game.

All we're primarily worried about with these tests is audio handling and stability!

Prerequisites to test

Files to download

  1. Download the testing module that has the new audio engine included:
    • d3d8.zip
      • Replace any files if prompted. Do not change anything within the d3d8.ini file except for the DisplayMode or WndModeBorder features.
  2. Ask us which SH2 PC executable to test with and download the appropriate one below (Right Click > Save As):

IMPORTANT!!! Please leave a post here saying you're interested in testing and we will tell you what executable to download for testing. We need a pool of people to test all executables so it's very important that we disperse the different executables out accordingly!

Please ask which executable to use for testing before actually testing!!

Submitting your notes

It's just as important for us to know everything went smoothly as it is if there's any issues. Once you've concluded your tests please submit the following information to us:

Thank you for your help!

We want this new feature to be as solid and stable as possible upon public release, so we appreciate your help in testing!

Volunteered testers:

Playtester Version Status
vStar925 1.1 Awaiting notes
MasterDarkSeid DC Notes received. DC - Audio looping.
FlintStride 1.1 Awaiting notes
Gwektro DC Notes received. DC - Audio looping.
PedroC47 1.0 Notes received.
Balthazor44 1.1 Notes received.
patrucksu DC Awaiting notes
wicstarry 1.0 Awaiting notes
Veynam 1.1 Awaiting notes
MarioTainaka DC, 1.0 Notes received. DC - Audio looping. 1.0 - No major issues.
shpatter DC Notes received.
Sumea 1.1 Notes received. 1.1 - Audio looping.
DaniloElectricMonkeys 1.0 Awaiting Notes
vStar925 commented 2 years ago

I'm interested in testing this. Which exe do I need?

Polymega commented 2 years ago

Hi @vStar925, Thanks for your interest! Please use the v1.1 executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site.

MasterDarkseid commented 2 years ago

What executable do i need.

vStar925 commented 2 years ago

I am also fairly new to using Github. How would you like the information sent to you after testing?

Polymega commented 2 years ago

Hi @MasterDarkseid , Thanks for your interest! Please use the DC executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site. Please note that most of us have not yet adopted Windows 11.

@vStar925 Once you are done testing just share the following below. I filled them out as an example:

FlintStride commented 2 years ago

I'd love to help playtest the new audio engine. Which executable should I use?

Polymega commented 2 years ago

Hi @FlintStride , Thanks for your interest! Please use the v1.1 executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site.

Gwektro commented 2 years ago

Absolutely want to test this!

Polymega commented 2 years ago

Thanks @Gwektro! Please use the DC executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site.

MasterDarkseid commented 2 years ago

Hi @MasterDarkseid , Thanks for your interest! Please use the DC executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site. Please note that most of us have not yet adopted Windows 11.

@vStar925 Once you are done testing just share the following below. I filled them out as an example:

  • Game Version: 1.1
  • Operating System: Windows 10 64-bit
  • CPU: AMD Ryzen 3700X
  • Game played to completion? Yes
  • Any issues to report? None

Okay so i've went to the prison after the Abstract Daddy boss. Did the innocent man puzzle to unlock the cuff. Then once i used the key i've got a soft lock. Saying No PS2 format Detected.

Edit : So i did broke the game. But i was able to finish it despite me having told that the soft lock would occur each game that's wrong. In that regards if you want to reproduce it and maybe fix it if you manage to reproduce it. How did he happen ? i've used the key and did a quick save at the same time. And he occured. I did multiple run to test different endings.

Game is running smoother than previously, I've streamed it but... As a idiot i forgot to set the option to keep the broadcast. If you want me to do it again i will.

Edit : I did all we could can do try break the game. i've tried spamming locked doors. Tried spam flashlight on/off , tried chainsawing walls , creatures , bosses. I've gone though every room , done all conditions for 10 star run except for the difficulty. Which i plan to tomorrow just to test the patch even more.

All i can say it's the frame skip , lag and stutter have vanished except stutter that is still happening at specific locations and a freeze for a second in the appartment nothing too crazy but he didn't break the game. So i feel kind of happy with the fix.

PS: i like the new Menu writing. Or maybe it's me dreaming but before the patch the writing wasn't like that might be wrong.

PedroC47 commented 2 years ago

I'd like to enlist as play tester, please. Which exe?

Balthazor44 commented 2 years ago

Hello, I would love to help playtest, please let me know which exe you would like me to use. I am running Windows 11 if that makes a difference. Thank you!

patrucksu commented 2 years ago

I'd like to be a play tester, which exe should I download? I'm using windows 10

Polymega commented 2 years ago

Thank you all for your help with playtesting!

@PedroC47 Please use the v1.0 executable for testing.

@Balthazor44 Please use the v1.1 executable for testing.

@patrucksu Please use the DC executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site.

wicstarry commented 2 years ago

Hello! I'm interested in testing! I'm on Windows 10. Which .exe should I use?

Polymega commented 2 years ago

Hi @wicstarry, Thanks for your interest! Please use the v1.0 executable for testing.

Once you are finished testing, you can redownload and use the executable provided on the project site.

PedroC47 commented 2 years ago

Just before I start playing I have a question:

I use a Logitech G432 and usually use their audio software that adds surround sound to games. Do I test the game without adding it to the software or do I add it?

Polymega commented 2 years ago

You can try using your Logitech G432 solution to the game. However, this being an old game, it may not work. We include DSOAL with our project as this adds 3D audio back to the game.

Veynam commented 2 years ago

Hi, a huge fan of the project here, been following it for a couple of years and I'd be glad to lend any help I can.

Which exe should I get? Also, out of curiosity, what are the differences between the versions?

Polymega commented 2 years ago

Hi @Veynam, Thanks for offering to test! Please use the v1.1 executable for testing.

Executable differences:

Our project supports all three executables for the game. We do all our preliminary tests on 1.0. Because of that, we don't need as many people testing 1.0.

MarioTainaka commented 2 years ago

Hey there i'd like to test this out too. I've worked on my own audio related project using your amazing work as a base and I do have history working with Criware formats primarily with Sonic games. Which exe do I need to test?

Polymega commented 2 years ago

Thanks for offering to test, @MarioTainaka! Please use the DC executable for testing.

I think you should be fine to use your HDC voice pack with this. In fact, this might be good to ensure other fan audio packs will also work correctly. Thanks!

MarioTainaka commented 2 years ago

Thanks for offering to test, @MarioTainaka! Please use the DC executable for testing.

I think you should be fine to use your HDC voice pack with this. In fact, this might be good to ensure other fan audio packs will also work correctly. Thanks!

Noted! I'll start tonight.

shpatter commented 2 years ago

Hi, i want to be a tester

MarioTainaka commented 2 years ago

Thanks for offering to test, @MarioTainaka! Please use the DC executable for testing.

I think you should be fine to use your HDC voice pack with this. In fact, this might be good to ensure other fan audio packs will also work correctly. Thanks!

@Polymega Just tested it out on my 3 systems with my HDC and there's a big issue i'm facing right now.

System #1

Game Version: DC Executable Operating System: Windows 10 64-bit CPU: AMD Ryzen 7 3700X Game played to completion? : No Any issues to report? : The game stops responding right away whenever a file from the voice.afs archive needs to be played with my HDC. I've gone through a combination of trying the exe listed on the site and the DC. So it appears to be the module.. HOWEVER just running the Audio Enhancement Pack from the site causes no issues at all. The module on the site works with everything no problem

System #2 Operating System: Windows 10 64-bit CPU: Intel I5 7200U Game played to completion? : No

Any issues to report: Same as System #1

System #3

Operating System: Windows 10 64-bit CPU: Ryzen 3 1200 Game played to completion? : No

Any issues to report: Same as System #1 and #2

Polymega commented 2 years ago

Hi @shpatter, Thanks for offering to test! Please use the DC executable for testing.

@MarioTainaka The files within voice.asf must have the extension adx, but the actual content can be in either adx or wav format. Can you verify your audio files within voice.asf are either adx or wav? I can't remember the sample rate of the dialogue files off the top of my head, but are they the same as either the vanilla files or the EE files?

MarioTainaka commented 2 years ago

Hi @shpatter, Thanks for offering to test! Please use the DC executable for testing.

@MarioTainaka The files within voice.asf must have the extension adx, but the actual content can be in either adx or wav format. Can you verify your audio files within voice.asf are either adx or wav? I can't remember the sample rate of the dialogue files off the top of my head, but are they the same as either the vanilla files or the EE files?

Just checked the voice files for the EE are sampled at 44100hz while mine are at 48khz. Super weird issue never expected this to happen lol

Polymega commented 2 years ago

Super weird issue never expected this to happen lol

Try changing that just to see. We'd have to ask Gemini if his audio solution is written to only expect 44,100 Hz here or not.

MarioTainaka commented 2 years ago

Super weird issue never expected this to happen lol

Try changing that just to see. We'd have to ask Gemini if his audio solution is written to only expect 44,100 Hz here or not.

@Polymega that fixed it! also tested my light version of the mod which uses adx files instead of wav. Everything works at 44100hz. Still i'd recommend supporting both sampling rates especially because 48hz is a standard for JP developed games and Criware recommends encoding at 48khz

MarioTainaka commented 2 years ago

@Polymega I'll start a full playthrough later tonight and report back.

shpatter commented 2 years ago
Gemini-Loboto3 commented 2 years ago

I have no idea why the code would fail with any specific frequency, it's not hardcoded at 44khz max, it should be able to use anything as long as it doesn't flood the buffers. Game's primary DirectSound buffer is 48khz, but then again most recent gaming libraries don't bother to go past 44k because the differences isn't even that noticeable.

umbrellacorp53 commented 2 years ago

I'd like to test on the Steam Deck. The situation is a little different with the Deck regarding the ini as it requires a couple of special tweaks from here. Minus the tweak to AudioClipDetection since it is no longer crashing the game with the new audio engine fix.

Should I test for the Deck officially or wait until there is a more official support?

MarioTainaka commented 2 years ago

@Polymega @Gemini-Loboto3 here are two sample audio files. Hoping it helps. Test Audio.zip

Polymega commented 2 years ago

@shpatter

Operating System: MacOS (Windows 10 64-bit using Crossover (like Wine)) Any issues to report? No ability to play, as after the initial cut scene just a gray screen appears. I want to note that before when I played there was no such problem. I think this is a problem with executable.

You can try using a different executable. For these tests though, it's probably best to play on a native Windows OS as that's what the game/project was made for.

@umbrellacorp53 If you'd like to test go for it but the main focus for now is stability on Windows.

MarioTainaka commented 2 years ago

@Polymega

System #1 Game Version: DC Executable Operating System: Windows 10 64-bit CPU: AMD Ryzen 7 3700X Game played to completion? : Yes (In Water Ending)

System #2 Operating System: Windows 10 64-bit CPU: Intel I5 7200U

System #3

Operating System: Windows 10 64-bit CPU: Ryzen 3 1200

Issues: 48khz wave files aren't supported, 44100hz adx files aren't supported, stuttering still remains but seems to become less and less the more cores\threads you throw at the game. Overall CPU usage is higher now but low end systems in my case my 2nd system with 2 cores and 4 threads had alot of stutters i'd say even more then the current stable build.

EDIT:

No weirdness with the audio to report on my end so far. I tried loading into areas using quick saves a ton, tried getting the game to play multiple dialogue streams at the same time.

MasterDarkseid commented 2 years ago

Hi @MasterDarkseid , Thanks for your interest! Please use the DC executable for testing. Once you are finished testing, you can redownload and use the executable provided on the project site. Please note that most of us have not yet adopted Windows 11. @vStar925 Once you are done testing just share the following below. I filled them out as an example:

  • Game Version: 1.1
  • Operating System: Windows 10 64-bit
  • CPU: AMD Ryzen 3700X
  • Game played to completion? Yes
  • Any issues to report? None

Okay so i've went to the prison after the Abstract Daddy boss. Did the innocent man puzzle to unlock the cuff. Then once i used the key i've got a soft lock. Saying No PS2 format Detected.

Edit : So i did broke the game. But i was able to finish it despite me having told that the soft lock would occur each game that's wrong. In that regards if you want to reproduce it and maybe fix it if you manage to reproduce it. How did he happen ? i've used the key and did a quick save at the same time. And he occured. I did multiple run to test different endings.

  • Game Version: DC executable
  • Operating System: Windows 11 64-bit
  • CPU: Intel Core i7 10700K
  • Game played to completion? Yes
  • Any issues to report? Except the issue cited above with a few stutter and a single freeze at the appartment. I had no issue at all. If you remember me about the framerate issue i had on twitter. This is not a thing anymore.

Game is running smoother than previously, I've streamed it but... As a idiot i forgot to set the option to keep the broadcast. If you want me to do it again i will.

Edit : I did all we could can do try break the game. i've tried spamming locked doors. Tried spam flashlight on/off , tried chainsawing walls , creatures , bosses. I've gone though every room , done all conditions for 10 star run except for the difficulty. Which i plan to tomorrow just to test the patch even more.

All i can say it's the frame skip , lag and stutter have vanished except stutter that is still happening at specific locations and a freeze for a second in the appartment nothing too crazy but he didn't break the game. So i feel kind of happy with the fix.

PS: i like the new Menu writing. Or maybe it's me dreaming but before the patch the writing wasn't like that might be wrong.

@Polymega

Okay so did a second run as a 10 stars run this time. And he crash at the first door to go in the hotel. but luckily this time i got a VOD of it. I want to mention that another issue is happening sincey ou added both stomp and kick. In the bug room to farm the fighting kills make it very hard if the kick happen but the hitbox kick the wall.

Like here at 1:34:04 watch 10-15s you will see what i'm talking about.

https://www.twitch.tv/videos/1468922071

Second this is one what you were looking about. It's crash due to an audio loop. When opening the door to go to the hotel after picking the cinderella item on the fountain.

Watch the link above at 1:54:50. Edit : https://www.twitch.tv/videos/1469034488

Do you need more footage or will that be enough. I've done the game two times the first had the "no PS2 format detected" mentioned in my previous post. However this was due to me pressing quick save and using the key at the same time.

The second had the crash with audio looping.

Further notes : The game have a bit of lag , stutter and rarely a freeze that last like 1s. But, i don't have the issue i had before it's clearly an improvement. In case you missed my post above i'm DC executable. Feel free to watch the VOD all you want.

Gemini-Loboto3 commented 2 years ago

@MarioTainaka

here are two sample audio files. Hoping it helps. Test Audio.zip

Your waves contain an unaligned LIST tag, which is irrelevant meta data some software adds as a signature (most likely ffmpeg). Either remove it (Audacity has a clear option for this) or make it aligned to 4 bytes. This is not an issue related to bit rate, it's just odd chunk sizes for the RIFF standard.

44100hz adx files aren't supported

EE uses 44100hz ADX, so it's more like a conversion problem on whatever program you're using.

@MasterDarkseid

Second this is one what you were looking about. It's crash due to an audio loop. When opening the door to go to the hotel after picking the cinderella item on the fountain. Watch the link above at 1:54:50. Edit : https://www.twitch.tv/videos/1469034488

Does this crash produce any error on screen? If it's Criware failing somewhere in the process it should spit out an explicit error message with the name of the interested faulty function.

Sumea commented 2 years ago

Hello. I too am willing to test the game's new audio engine. My computer is "The most average gaming PC" as reported by Linus Tech Tips in 2021; with Intel i7 4970K, a matching GPU and so on. If you want Effing insane testing I can also report results on a intel atom x5 based tablet/laptop hybrid. (amazing if it even boots, but original SH2 port should do at least that on the machine). I run Windows 10 64 bit on both, Professional variant, but nothing exotic like LTSB or Server edition etc.

If you still are listing out deployment, which executable should I go with?

MasterDarkseid commented 2 years ago

@MarioTainaka

here are two sample audio files. Hoping it helps. Test Audio.zip

Your waves contain an unaligned LIST tag, which is irrelevant meta data some software adds as a signature (most likely ffmpeg). Either remove it (Audacity has a clear option for this) or make it aligned to 4 bytes. This is not an issue related to bit rate, it's just odd chunk sizes for the RIFF standard.

44100hz adx files aren't supported

EE uses 44100hz ADX, so it's more like a conversion problem on whatever program you're using.

@MasterDarkseid

Second this is one what you were looking about. It's crash due to an audio loop. When opening the door to go to the hotel after picking the cinderella item on the fountain. Watch the link above at 1:54:50. Edit : https://www.twitch.tv/videos/1469034488

Does this crash produce any error on screen? If it's Criware failing somewhere in the process it should spit out an explicit error message with the name of the interested faulty function.

Nope he just crash and i have to close it myself.

Edit : Just finished it a third time with no issues. Except the Hyper doesn't count all the kills you do with it. I was trying a 10 star run if you familiar with speedrun. Every kill is either counted as fighting or shooting kills depending if you kill close or the furthest. and most of the time kill works but sometimes he just doesn't count at all. I mean he literally doesn't count the kills like 0.

Other than that there's still a few stutters , little lag/freeze but had no issues at all. Crash is just random i guess.

MarioTainaka commented 2 years ago

@MasterDarkseid Alright i'll take a look at that. You are correct I did use FFMPEG on the initial 5:1 audio files from the disc but re-mixed and re-encoded them to Stereo in Goldwave. Wouldn't a completely new file without those tags be generated though?

As for the ADX files the game crashes whenever you start the game in g_start.adx needs to play. Thing is... that file is actually from the EE.

Polymega commented 2 years ago

@Sumea Thanks for offering to test! Please use the v1.1 executable for your testing.

@MasterDarkseid I'll keep an eye on the bug room and see if we need to make adjustments for his kick there at a later time. As for the crash you had at the lake/hotel: I'm thinking this might be due to the DC executable you are using. Out of the three, we believe the DC executable is the least stable (which is why I'm having more people test it than any other executable). If you wouldn't mind, please try testing again using the 1.0 executable and see if you have another crash similar to the one you experienced here.

@MarioTainaka

Wouldn't a completely new file without those tags be generated though?

It might depend on the software being used. Some might add their own metadata in. For example, I know Photoshop adds its own type of metadata to PNGs that other programs don't. Gemini has mentioned that programs like Audacity have a feature to flush this meta data out. Might be worth trying.

MarioTainaka commented 2 years ago

@Polymega Did another run earlier today on another PC. This one actually isn't mine, and the game crashed with looping sound and no error messages of any kind in bluecreek apartments when you go to room 109. This was the very first crash. Super random. on my own PC's it ran flawlessly

CPU:A8-6600k

OS: Windows 10-64 bit

Game Executable:DC

Issues: Random CTD with no errors. very hard to reproduce.

Polymega commented 2 years ago

@MarioTainaka If you get another crash like that in your tests, please switch over to the 1.0 executable and see if it keeps happening there.

MarioTainaka commented 2 years ago

@MarioTainaka If you get another crash like that in your tests, please switch over to the 1.0 executable and see if it keeps happening there.

Noted!

MarioTainaka commented 2 years ago

@Gemini-Loboto3 Clearing the metadata and resaving using Goldwave and Audacity does the trick! I'll finish resvaving all the files and convert to ADX to test that as well.

DaniloElectricMonkeys commented 2 years ago

Hey, I'm interested in testing!

Gwektro commented 2 years ago

Okay, so I finished the main game late last night & suffice to say, this definitely worked pretty good on the first run albeit some minor quirks. I completed the game which is already a huge improvement!

I tried a bunch of things to stress test it like spam saves, walk around awhile in the same area, then reload & go super fast through rooms, spamming menus, item sounds, etc. Performance wise, this is a noticeable improvement! The stutters can still occur in the normal spots in the game on my old potato PC, but its usually over very quickly in like half a second each stutter. Usually they'd carry on for seconds & the open town areas would get a bit annoying.

I have a bunch of notes of some of the quirks I mentioned earlier saved I'd like to share once I'm confident enough its exclusively issues from this testing module (since I know the main game has its own issues that just occasionally happen too) & then later today, I'll play through the sub scenario. So hopefully that'll come within the next 4-5 days? I'm a bit busy with work & IRL stuff so I just want to be a bit realistic about it.

For now, I'll list the only major audio loop issue & crash at the very end in the double Pyramid Head boss room where I reloaded a save for the 5th time because I suck doing the great knife strat :') & after reloading the save during the audio loop, the game black screened & locked up until I eventually just ended the program manually on task manager. No crash report or anything. https://streamable.com/suropm

Thanks for the playtest! This is awesome work.

Game Version: DC Operating System: Windows 10 64-bit CPU: Intel Core i7 3770K (Ivy Bridge) Game played to completion? Yes (Leave Ending) Any issues to report? More to come ^

MarioTainaka commented 2 years ago

@Polymega Did Two more playthroughs on my main system. First one was with DC exe where the audio start looping after the hangman puzzle once you unlock the cuffs. I carried on until the game crashed with a generic Windows Error.

Second playthrough was with the 1.0 exe the stutters are still there but almost eliminated, ALMOST. no weird crashes either no matter how hard I stressed the audio engine.

Game Version: DC Operating System: Windows 10 64-bit CPU: Ryzen 7 3700X Game played to completion? No (Crashed after the hangman puzzle with looping audio)

Game Version: 1.0 Operating System: Windows 10 64-bit CPU: Ryzen 7 3700X Game played to completion? Yes (Leave Ending)

Sumea commented 2 years ago

After initial putting long to longplay run. Basically taking it purposefully slow just to let most music and ambient go through their loop points, playing around letting just generally sound and special places play out their sound to see if any looping issues happen as I remember them happening on vanilla SH2PC. Generally there was no problems. No slowdowns or other performance issues that I detected, though I have also nominally powerful hardware. During my testing occasionally, usually when new music or background track of other nature gets loaded, maybe, there would be a microstutter, not much but noticeable and nothing that would happen on console versions, but also hard to determine to be problem in this build and not combination of my hardware and software casusing it. I experienced single crash in prolonged, five hour session in hotel after watching the video tape. After walking back down the stair way now in other world hospital the game crashed to a error screen about SndEngine - I forgot to note the exact error message, OK closing the program. The crash did not reproduce after launching the game again and loading a save that was just in the same moment. I feel bad for not screenshotting the error message since I was just surprised it even happened. If I had to make bad guess, I'd guess that the long continuous runtime of the game contributed to the crash, though prior as said, nothing else but extremely occasional hitch happened wrong.

I am unsure currently. I am up to a speedy play of the game any time but I also feel like looking into stressing with prolonged runtime for possible crashes again.

Footage: https://www.youtube.com/watch?v=dZurcPMBIVM - Crash happening at between 5 hour mark and thirty seconds after that mark. TL;DR: Mostly fine. Possble data load related hitching, possibly just quirk of the game and my HW+OS existing together. One crash with SndEngine or something like that error window, after game had been running continuously for five hours. Did not personally notice any looping issues, while making sure that tracks looped at least once naturally - and more by just stalling.

Game Version: 1.1 Operating System: Windows 10 64-bit CPU: Intel Core i7 4970K Game played to completion? Yes (Leave Ending) (Crash and reload to finish)