search

elishacloud / dxwrapper

Fixes compatibility issues with older games running on Windows 10/11 by wrapping DirectX dlls. Also allows loading custom libraries with the file extension .asi into game processes.
zlib License
1.15k stars 82 forks source link

Fixed indexed draws with less than three indices #185

Closed dkollmann closed 1 year ago

dkollmann commented 1 year ago

Fixed indexed draws with less than three indices which causes an assertion in RTX Remix.

PatrickvL commented 1 year ago

Doesn't this prohibit drawing single line primitives?

dkollmann commented 1 year ago

Sounds good. I will get to it, once I am done merging master into my repository.

elishacloud commented 1 year ago

BTW, this same fix should probably go into the DrawPrimitive() function also.

dkollmann commented 1 year ago

It seems the assertion in RTX Remix is indeed wrong. The correct check still triggers the assertion.

elishacloud commented 1 year ago

Try changing this line to this:

BPP = Utils::GetBitCount(hWnd);

I realized it should not be the BackBufferFormat because that is always the same value.

elishacloud commented 1 year ago

Do you have an Nvidia graphics card? There is a bug with Nvidia that happens on a handful of games when you recreate the the d3d9 device too many times.

dkollmann commented 1 year ago

I built the debug version of RTX Remix and there is an assertion in it. I made made a pull request for removing it, let's see what comes back.

dkollmann commented 1 year ago

I got a reply and will look into that issue again later: https://github.com/NVIDIAGameWorks/dxvk-remix/pull/16#pullrequestreview-1413444321