search

elishacloud / dxwrapper

Fixes compatibility issues with older games running on Windows 10/11 by wrapping DirectX dlls. Also allows loading custom libraries with the file extension .asi into game processes.
zlib License
1.15k stars 82 forks source link

Debuginfo lights #196

Closed dkollmann closed 1 year ago

dkollmann commented 1 year ago

The debug view (Alt + D) now shows all the lights in the scene.

elishacloud commented 1 year ago

Is there a reason why the debug items are in the release build? Can we move them over to the debug build?

Also, I like to keep these items inside the Dd7to9 clause since they cannot be used in DirectDraw natively,

dkollmann commented 1 year ago

The thing is, that I need them in the release build. The proper solution would probably be to have a shipping or development configuration.

Ah yeah makes sense. What do you think about copying the data to the device object instead of calling DirectX functions? I wanted to avoid running functions which need to enter locks.

elishacloud commented 1 year ago

What do you think about copying the data to the device object instead of calling DirectX functions?

Yes, great idea. We can also put them into another class and file to keep the main file cleaner.

elishacloud commented 1 year ago

I'll merge these changes and then move them into a new class afterwards.

elishacloud commented 1 year ago

I moved the debug code to a new class. See here: 552c9837a1ded3f3faabed8a6a35cdf10b554a86