elishacloud / dxwrapper

Fixes compatibility issues with older games running on Windows 10/11 by wrapping DirectX dlls. Also allows loading custom libraries with the file extension .asi into game processes.
zlib License
1.15k stars 82 forks source link

setup CI #215

Closed Trass3r closed 10 months ago

Trass3r commented 10 months ago

To make sure compiling the project doesn't depend on some local machine-specific setup.

https://github.com/elishacloud/dxwrapper/compare/master...Trass3r:dxwrapper:master#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

See https://github.com/Trass3r/dxwrapper/actions/runs/5779138294 d3dumddi.h is missing. The WDK is installable, or might even be installed already but it still doesn't find it. https://github.com/Trass3r/dxwrapper/actions/runs/5784006311/job/15673863504

elishacloud commented 10 months ago

Yes, the d3dumddi.h comes from the Windows Driver Kit (WDK). As stated in the readme:

The project requires both the Windows 10 SDK and WDK (needs to have matching SDK and WDK versions installed).

The current version can be seen here, though it may change later. In other words, you need to install both SDK 10.0.19041 and WDK 10.0.19041 for dxwrapper to compile. BTW: 19041 should be Windows 10 version 2004

See here: https://learn.microsoft.com/en-us/windows-hardware/drivers/other-wdk-downloads

elishacloud commented 10 months ago

The WDK is installable, or might even be installed already but it still doesn't find it.

I guess that both SDK and WDK are not the same versions. You can try changing the the SDK version to match whatever WDK you have installed.

Trass3r commented 10 months ago

You're right: https://github.com/elishacloud/dxwrapper/commit/d24cdf028bee04bec99ba97622d2c1a79c85a4de https://github.com/Trass3r/dxwrapper/actions/runs/5787792910 I had to make that change locally too before since I don't use that particular SDK version. And the WDK header I just copied from somewhere back then.

Full CI file now: https://github.com/elishacloud/dxwrapper/compare/master...Trass3r:dxwrapper:ci#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

elishacloud commented 10 months ago

Thanks @Trass3r!