search

elison22 / Team-Rocket-Catan

Settlers of Catan for CS 340
0 stars 0 forks source link

Don't receive largest army #37

Closed gseccles closed 9 years ago

gseccles commented 9 years ago

This is kind of a cop out, because I can't figure out how to reproduce it at all. However, I was in a game where I had the longest road card, and played a knight. The knight was my third knight, so I should have gotten the largest army card. I had 8 points, so I also should have won the game. I didn't receive the largest army card or the points and the game just continued on normally. I don't know if it's relevant, but I also had two monument cards in my deck, so I could have just played those at any time and won the game. Someone try to repro this a time or two. If no one else can, then we can just close it.

gseccles commented 9 years ago

This might be issue #33 now that I look at it. I might not be able to repro it because I pulled while testing and it got fixed. Anyone know for sure?

awall59 commented 9 years ago

well I think chad already fixed this earlier today. He too should have received points, gotten largest army, and won after playing his third knight card but didn't get any of that even though it showed he played 3 knight cards. The issue was that he had 11 points and so the game was actually throwing errors because the view was originally coded specifically to be <= 10 but it didn't show anything. But now if a player has more than 10, we just reset the value to 10 so it doesn't throw an error and everything happens as it should

On Mon, Mar 2, 2015 at 2:10 PM, gseccles notifications@github.com wrote:

This is kind of a cop out, because I can't figure out how to reproduce it at all. However, I was in a game where I had the longest road card, and played a knight. The knight was my third knight, so I should have gotten the largest army card. I had 8 points, so I also should have won the game. I didn't receive the largest army card or the points and the game just continued on normally. I don't know if it's relevant, but I also had two monument cards in my deck, so I could have just played those at any time and won the game. Someone try to repro this a time or two. If no one else can, then we can just close it.

— Reply to this email directly or view it on GitHub https://github.com/elison22/Team-Rocket-Catan/issues/37.