Open raneem-ai opened 8 months ago
Hi Group Hazel Kyrk, thank you for your feedback! We will be sure to add more descriptive axis names. As for the interactive plot, in the markup section, we explained how to make it interactive: by clicking the lines of the key. Here is a screenshot from our file:
We look forward to your presentation as well :)
Hi! Really great job with your team's code so far! it flows in order, answers the project objectives and makes logical sense at most parts.
Just a few notes; for visualization make sure that plots are labeled correctly and provide adequate information for interpretation. Additionally, the code mentions an interactive plot, but it's not clear how it's implemented. You may want to double check that the interactive features are properly integrated and can be used by reviewers. There's a function definition "my_prices", but it's unclear how it's used in the code, consider adding more descriptive comments or docstrings to explain the purpose of each code block and its functionality. Finally some variable names are not descriptive enough (e.g., D, xhat, xbar). Ensure that variable names are meaningful and descriptive(or provide docstring text of what these variables correspond to).
Other than those slight issues, you guys are doing really good and we are looking forward to your final presentation!