Issue #1: Add option to protect all contribution pages

[ghost]

Adds a checkbox to the Honeypot settings page that lets admins protect every contribution page rather than specifically identified contribution pages.

As per my request in Issue #1

[elisseck]

Hi John,

I hear you on issue #1 - I think a 'select-all' box is a good idea for folks with larger sites who are seeing malicious activity. In testing, I found a couple of issues with this PR that need to be corrected before merging. Writing some basic unit tests for people to more easily test against is on my list but will take time.

• It looks like the If statement on line 19 of civihoneypot.php has been modified in such a way that all forms that civicrm builds (not just contribute forms) are always protected no matter what options are set in settings.
• Line 58 also needs to mirror line 19 so hook_form_validate fires for the same forms that hook_form_build does. I keep thinking there must be a better way but i'm not there yet.

Protecting more types of forms is on my list, but I think protecting all forms that are built (inward OR outward facing) is beyond what the scope of this extension should cover.

I may do some work on this feature request myself if you don't have more time, but I likely won't get to it within the next week or so.

Thanks!

[ghost]

Hi Eli,

Thanks for the quick reply and spotting my error. I rushed this out as we're absolutely one of those "larger sites who are seeing malicious activity".

[elisseck]

@mrlavalava I still found that particular commit to be protecting all forms no matter what - I need to write tests but my only available machine for dev right now is running windows with MAMP and I haven't gotten cv to work with that yet >_<. I found some time to write a quick fix and it should be working like we want it to.

@seamuslee001 I also added a validate for the settings form so it won't save settings if there isn't either an ID or the 'protect all' box checked.

Haven't tagged this as a new release yet but if you pull from master before I get around to that it should be working like we want it to. Let me know if there are more issues and thanks!