search

elisseck / com.elisseck.civihoneypot

Simple honeypot fields for CiviCRM Contribute forms
Other
3 stars 6 forks source link

[WIP] Support honeypot validation on Civi forms that are accessible to anonymous users #5

Closed monishdeb closed 4 years ago

elisseck commented 7 years ago

Hi Monish - thanks for the contribution!

I'm going to merge this because it's working for me and it adds some functionality where we had none before. I do think at some point we should have parity between event features and contribution features so it doesn't confuse people.

Right now it looks like we have "on for all forms", "on for some contribution forms and no event forms", "off for all forms". At some future point we probably want to add "on for some event forms and no contribution forms" to have parity. It doesn't feel important to me right away though.

Thoughts?

elisseck commented 7 years ago

Actually - I see you changed the title to [WIP] - should I wait to merge?

monishdeb commented 7 years ago

@elisseck as Joe has indicated there are some other online forms which are accessible to anonymous users. So I am going to support the validation for those forms too, the reason why I marked it with [WIP]. Will ask ya for review after I include the remaining fixes.

elisseck commented 4 years ago

There are a bunch of conflicts now and i'm not 100% sure what the thought process was behind this one so i'm going to close for now. Feel free to re-open if there is still interest.