Australian Greens changes

elisseck / com.elisseck.civihoneypot

Simple honeypot fields for CiviCRM Contribute forms

Other

3 stars 6 forks source link

Australian Greens changes #6

Closed seamuslee001 closed 4 years ago

seamuslee001 commented 6 years ago

Update to use the latest civix,
namespace all settings putting honeypot_ infront of them
make all settings apply to every domain whenever set and clear cache after saving settings.
Add in extension upgrade step to migrate settings to new namespace

elisseck commented 6 years ago

Hi Seamus,

Just wanted to say i've seen this and thanks for making a contribution!

Since I didn't have any time to write tests for this previously... it's going to take me awhile to get to it - but at a cursory glance looks good to me.

MegaphoneJon commented 3 years ago

This upgrade didn't keep my old settings - I don't know why, and I'm not particularly fussed, but I just thought I'd mention it.

elisseck commented 3 years ago

@MegaphoneJon Thanks for that report! I believe this PR renamed all of the settings for better compatibility with multi-site setups.

I remember thinking the upgrade path number was a little suspicious, but I don't know a huge amount about how you need to number upgrade fxns... I just remember someone telling me it's important and I have a feeling it just didn't run :). I'll take a look into it soon(tm). Could be significant for someone who dumped a huge array of IP ranges into that setting for whatever reason.

MegaphoneJon commented 3 years ago

FWIW the upgrade DID run, and I happened to test on a multi-site instance.