elitcloud / elit

🔠 Evolution of Language and Information Technology
https://elit.cloud
Other
47 stars 7 forks source link

A re-implementation of Deep Biaffine Attention for Neural Dependency … #17

Closed hankcs closed 6 years ago

hankcs commented 6 years ago

Hi elit team,

This is a re-implementation of Stanford's "Deep Biaffine Attention for Neural Dependency Parsing" at ICLR 2017.

This parser has been well tested and documented. More information can be found at this file.

Hope this parser can enrich this project. Thanks.

Han He

imgarylai commented 6 years ago

@hankcs Appreciate your pull request! I will review this pull request as soon as I can. Thank you. :)

imgarylai commented 6 years ago

Hello @hankcs, I'm reviewing your code, and I want to ask you some questions.

There is no problem to run your code, all the configurations are clear. However, could you tell me which dataset you have tested? From the GloVe dataset, did you try all four datasets, the pre-trained word vectors? If not, which has been tested? Also, would you please let me know which Conll dataset did you use and the source? It would be great that we can also put dataset source reference in the tutorial. People who are interesting in this project can get into it with lower barrier!

Again, I really appreciate your work!

hankcs commented 6 years ago

Sure,

  1. I've tested on the PTB-SD. As PTB is phrase tree structured, user needs to convert it to CoNLL. For resources of the conversion, one can refer to:
  2. The embedding file used is the glove.6B.100d.txt. The dimension must match with word_dims specified in config file. Users are free to use other embedding files, but be careful about the dimensions.

Please let me know if you have any questions. Thanks,

Han He

imgarylai commented 6 years ago

Thank you. This pull request is merged!