search

eliteSchwein / mooncord

Moonraker discord Bot
MIT License
133 stars 24 forks source link

Make logging to file optional #147

Closed ressu closed 3 years ago

ressu commented 3 years ago

It should be possible to both define the log file location and to disable the log file completely.

While it's beneficial in some cases to have a log file, in other cases it's not as useful. For example, when running in a Kubernetes container, the standard way of logging information is via stdout and stderr. If I want to run the container with a readonly root, I will need to separately prepare for log. Even though there are other uses for the temp directory too, this is one of the obvious things that should be configurable.

eliteSchwein commented 3 years ago

about the log config, sure i can add it.

about the temp dir, its a "fallback" solution for some temp stuff (timelapse, log, dumps and some other stuff) so i kinda cant remove it

ressu commented 3 years ago

Hah, I was about to discuss the log file requirement, but you happened to edit the comment while I was writing this.

I would prefer to have the temp directory as a configurable value too. Preferably following the XDG base directory standard specification, but even having an argument to change it is a good start.

eliteSchwein commented 3 years ago

configurable temp dir aswell? okay i will add it

eliteSchwein commented 3 years ago

implemented in 5d13788d396fd0bea0434d54c31173d0ce464546