search

eliteportal / data-models

data models for the elite project
https://eliteportal.github.io/data-models/
MIT License
1 stars 1 forks source link

Update-bsSeq-enums #38

Closed ameliakallaher closed 3 months ago

ameliakallaher commented 3 months ago

Updated enumerated values lists with options for unknown, not collected, not specified, and not applicable.

avanlinden commented 3 months ago

GH action is expected to fail. Running join_data_model.py script did not update the json-ld because changes are to columns that are ignored by schematic (e.g. columnType).

ameliakallaher commented 2 months ago

@avanlinden The template didn't update in DCA with these changes - I ran the Python line above as one of my commits, but perhaps not successfully?

avanlinden commented 2 months ago

The join_data_model.py script silently failed because we did not have schematic installed in the environment! Updated process to manually do this:

  1. run poetry install in the terminal
  2. run poetry shell in the terminal
  3. then run data_model_creation/join_data_model.py
  4. check to see that both data model csv and json-ld files get updated!
avanlinden commented 2 months ago

something weird happening with the totalReads.csv attribute, line 147 in the csv data model, preventing schematic from converting to jsonld