search

eliu / openshift-vagrant

Bring up a real OKD cluster on your local machine using Vagrant and VirtualBox
Apache License 2.0
57 stars 56 forks source link

openshift_node_labels no longer supported in OKD v3.11 #7

Closed brx75 closed 5 years ago

brx75 commented 5 years ago

As stated in https://docs.okd.io/3.11/install/configuring_inventory_file.html#configuring-node-host-labels.

You can no longer set the openshift_node_labels variable to change labels. See Node Group Definitions to modify the default node groups.

I think you have to remove

openshift_node_labels="{'node-role.kubernetes.io/compute': 'true'}"

from ansible-hosts template file

eliu commented 5 years ago

It's there due to backward compatibility reason. These old openshift release needs this property in order to work property. Currently there's no harm for okd 3.11 from my side. Let me know if you have proved it conflicts the functionality of your clusters.

brx75 commented 5 years ago

It fails during the run of /home/vagrant/openshift-ansible/playbooks/prerequisites.yml playbook

On Thu, Feb 21, 2019 at 3:38 PM Liu Hongyu notifications@github.com wrote:

It's there due to backward compatibility reason. These old openshift release needs this property in order to work property. Currently there's no harm for okd 3.11 from my side. Let me know if you have proved it conflicts the functionality of your clusters.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eliu/openshift-vagrant/issues/7#issuecomment-466022866, or mute the thread https://github.com/notifications/unsubscribe-auth/AAneam7VP_y6P9ea9I4iElwWYkNdySZcks5vPq9IgaJpZM4bHLJs .

eliu commented 5 years ago

@brx75 thanks for the feedback. now i can reproduce it. Will get back to you if any progress on this.

eliu commented 5 years ago

@brx75 this issue has been fixed. please give it a try to check if everything is ok. my laptop's available memory is not enough to bring up 3 vm nodes for OKD 3.11.

brx75 commented 5 years ago

I'll check. About memory I found that 2GB seems too low for master node

eliu commented 5 years ago

Right, therefore all nodes' default memory has been increased within this fix.

eliu commented 5 years ago

Currently 3GB for master, and 2GB for nodes.

eliu commented 5 years ago

This issue is going to be stale since no further response for a while. Free free to re-open it if you want.