search

eliukblau / pixterm

Draw images in your ANSI terminal with true color
Mozilla Public License 2.0
971 stars 52 forks source link

Added go.mod support #12

Closed diamondburned closed 4 years ago

eliukblau commented 5 years ago

Thank you. I will leave this PR on standby, while the support of Go Modules is not yet official. Only from upcomming version 1.13, modules become official. We will wait until then.

Go Modules in 2019

mattn commented 5 years ago

I feed this is good to merge. Thought?

mattn commented 5 years ago

Current implementation have a problem that can't build with latest go-colorful. And most users using go1.13 faice this issue.

eliukblau commented 5 years ago

Yeah, it is in the making. I have had little time for this. Thank you for your interest :)

It will be published officially along with a couple of new patches and functionalities from contributors. Give me time ;)

MichaelMure commented 4 years ago

I can confirm that it would help, now that go1.13 is here. Also, current code use go-colorful v0.9, so not the version used in this PR.

mattn commented 4 years ago

Why don't you merge this?

eliukblau commented 4 years ago

https://github.com/eliukblau/pixterm/pull/12#issuecomment-541458346

https://github.com/eliukblau/pixterm/issues/11#issuecomment-487462178

https://github.com/eliukblau/pixterm/pull/8

eliukblau commented 4 years ago

Solved in v1.3.0

Thanks @diamondburned, @mattn, @MichaelMure for the comments about this and your interest 👍