search

elixir-circuits / circuits_uart

Discover and use UARTs and serial ports in Elixir
Apache License 2.0
189 stars 48 forks source link

Fix @specs to match GenServer specs #27

Closed fazibear closed 7 years ago

fazibear commented 7 years ago

This PR will fix all @specs

Because most of the functions are forwarded to GenServer, we need to match specs. This will make dialyzer happy.

sourcelevel-bot[bot] commented 7 years ago

Hello, @fazibear! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

fhunleth commented 7 years ago

Thanks! I agree that this should definitely be updated.

One question: Shouldn't it be changed to GenServer.server instead of GenServer.name?

fazibear commented 7 years ago

@fhunleth yes, right! Will fix that.

fazibear commented 7 years ago

Fixed.

fhunleth commented 7 years ago

Thanks!