search

elixir-circuits / circuits_uart

Discover and use UARTs and serial ports in Elixir
Apache License 2.0
189 stars 48 forks source link

Add ignore parity option (only unix) #49

Closed fazibear closed 6 years ago

fhunleth commented 6 years ago

Cool - although I don't even want to know what device caused you to go down the ignore parity path.

The change looks good. Could you squash the commits and put a "(Linux/OSX only)" comment next to the ignore option in the docs?

wzin commented 6 years ago

@fhunleth we work with a protocol that requires the parity bit to have a purpose different from the standard specification. The parity bit is used as a delimiter between multi-packet logical messages. Bad idea.

fhunleth commented 6 years ago

Wow.

Thanks for the PR!