search

elixir-cldr / cldr

Elixir implementation of CLDR/ICU
Other
447 stars 33 forks source link

Mistakes in DEVELOPMENT.md #160

Closed josevalim closed 2 years ago

josevalim commented 2 years ago

Hi @kipcole9,

I am going through DEVELOPMENT.md and I believe it must be outdated in some places.

  1. export $CLDR_REPO must not have the $ character

  2. Some commands use MIX_ENV=gen but there is no such environment

  3. Step "Download the up-to-date ISO currency database" does not work at that moment. I have skipped it for now.

I will drop more comments/edit as I run into things.

kipcole9 commented 2 years ago

My apologies José, I have updated DEVELOPMENT.md (thanks for the edits) and had to adjust one of the environment compile paths. I have pushed a commit which, I think, means all is aligned again.

On 1 Nov 2021, at 2:54 pm, José Valim @.***> wrote:

Hi @kipcole9 https://github.com/kipcole9,

I am going through DEVELOPMENT.md and I believe it must be outdated in some places.

export $CLDR_REPO must not have the $ character

Some commands use MIX_ENV=gen but there is no such environment

Step "Download the up-to-date ISO currency database" does not work at that moment. I have skipped it for now.

I will drop more comments/edit as I run into things.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elixir-cldr/cldr/issues/160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAD4F3AIR55HGKKUZZHZ7TUJY2TLANCNFSM5HDLDQ5Q.

josevalim commented 2 years ago

Beautiful, thank you! :heart: