search

elixir-cldr / cldr

Elixir implementation of CLDR/ICU
Other
440 stars 33 forks source link

Replace `"\u00A0"` space character for regular space character en-GB #218

Closed ulissesalmeida closed 9 months ago

ulissesalmeida commented 9 months ago

When writing tests in our application code we noticed the spaces generated for en-GB currency in iso format isn't a regular white space character. It's "\u00A0" (unicode characer escaped in Elixir). Is it expected? I think it might not, all other ocurrences of space character in the same file it's a regular space character.

I'm not sure if this is an error, if it should be fixed here or somewhere else upstream. It caused confusion among my colleagues, that's why I'm raising it up here.

What do you think? Is it something that needs to be fixed?

kipcole9 commented 9 months ago

@ulissesalmeida thats for the PR. However the data used by this library is fully maintained by the CLDR team. From time-to-time the formats change for any given data element in any given locale.

In CLDR 43 which is the current release, several formats now use non-breaking space (0x00A0) which, I think you would agree, makes more sense in currency formats since you wouldn't expect line wrapping to occur between the current symbol and the number.

I appreciate that this sometimes results in failing tests after an upgrade but these changes don't occur often.

ulissesalmeida commented 9 months ago

@kipcole9 TIL

Thank you so much for the explanation. ❤️