elixir-cldr / cldr_dates_times

Date & times formatting functions for the Common Locale Data Repository (CLDR) package https://github.com/elixir-cldr/cldr
Other
69 stars 13 forks source link

Version 2.19 API changes? #51

Closed tjchambers closed 4 months ago

tjchambers commented 4 months ago

The public API seems to have changed between version 2.18.1 and 2.19.1. Not suggesting this should mean a major version bump, but IMO it should be noted in the changelog as a change.

Example:


          * gmt_format/0
          * time_formats/0
          * time_formats/1
          * time_formats/2
          * time_formats/3

    │
 82 │     {:ok, date_formats} = Cldr.DateTime.Format.date_formats(locale, :gregorian, Sct.Cldr)
    │                                                ~

    │
    └─ lib/sct_web/formatter.ex:82:48: SctWeb.Formatter.default_full_format/1

I believe this was changed from DateTime.Format.date_formats to Date.formats .

There may be similar other API changes.

tjchambers commented 4 months ago

As a side comment I believe the docs WERE changed.

kipcole9 commented 4 months ago

@tjchambers sorry for the inconvenience, there is no intent to change the public API so definitely a bug. I've fixed that and published ex_cldr_datetimes 2.19.2 with the following changelog entry:

Bug Fixes

Thanks again for the report.