search

elixir-cldr / cldr_territories

Territory formatting functions for the Common Locale Data Repository (CLDR) package https://github.com/elixir-cldr/cldr
Other
23 stars 11 forks source link

Fix doc references to Cldr.known_locale_names/0 in backend #18

Closed kipcole9 closed 3 years ago

kipcole9 commented 3 years ago

Some doc references in the backend used #{inspect __MODULE__} when they should have been #{inspect backend}. These are now fixed and correctly refer to Cldr.known_locale_names/0.

Schultzer commented 3 years ago

Thanks @kipcole9, is there a need to update the lock file in this PR? Some of the tests are failing and I'm not sure if that's related.

kipcole9 commented 3 years ago

Ahhhh, good points. There are some changes to validity checking in ex_cldr version 2.23.0 as of commit a6810b9. As a result, some error returns are different.

Therefore there are some test failing where a territory code was considered invalid or unknown in previous releases which may now be valid. Or might even be valid, but unknown.

I'll send another PR that brings ex_cldr_territories back up to level with ex_cldr.

kipcole9 commented 3 years ago

Sorry for the delay in updating. I've aligned the corrections with the upcoming ex_cldr version 2.24 which is based upon CLDR 40 that releases in the next two weeks. On my test machine all tests pass so hopefully will be ok in CI as well.

I think there is one dialyzer error I need to track down. But I'm hoping you might consider release this version 2.3.0-rc.0 as a pre-release so I can also finish end-to-end testing on all packages, including ex_cldr_locale_names which also depends on ex_cldr_territories.

Schultzer commented 3 years ago

@kipcole9 I've released a new version to hex

kipcole9 commented 3 years ago

Thank you Benjamin, much appreciated.

On 20 Oct 2021, at 2:25 am, Benjamin Schultzer @.***> wrote:

@kipcole9 https://github.com/kipcole9 I've released a new version to hex

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Schultzer/cldr_territories/pull/18#issuecomment-946987750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAD4F6RC2HWSDHKQG3524DUHWZ2FANCNFSM5DHZZOUA.