File "conversion_factors.json" missing on compile

hl commented 5 years ago

When setting up a new project with:

defp deps do
  [
    {:jason, "~> 1.1"},
    {:ex_cldr_units, "~> 2.3"}
  ]
end

the compile steps fails with the following error:

==> ex_cldr_units
Compiling 8 files (.ex)

== Compilation error in file lib/cldr/conversion.ex ==
** (File.Error) could not read file "./priv/conversion_factors.json": no such file or directory
    (elixir) lib/file.ex:353: File.read!/1
    lib/cldr/conversion.ex:14: (module)
    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6
could not compile dependency :ex_cldr_units, "mix compile" failed. You can recompile this dependency with "mix deps.compile ex_cldr_units", update it with "mix deps.update ex_cldr_units" or clean it with "mix deps.clean ex_cldr_units"

I failed to see why the download mix task is not run and hope you can help.

kipcole9 commented 5 years ago

@hl My apoiogies for the sloppy hex packaging which omitted the ./priv directory. Fixed now in this commit and published on hex as version 2.3.3.

Sorry for the inconvenience. If you:

mix deps.update ex_cldr_units

You should be good to go.

hl commented 5 years ago

@kipcole9 absolutely no apologies needed! I’m really appreciative of all your hard work.

Thank you for taking the time to look at this issue.

elixir-cldr / cldr_units

File "conversion_factors.json" missing on compile #10