elixir-cldr / cldr_units

Unit formatting (volume, area, length, ...) functions for the Common Locale Data Repository (CLDR)
Other
16 stars 13 forks source link

Documentation for adding new unit localizations #34

Closed ribanez7 closed 1 year ago

ribanez7 commented 1 year ago

The only way I have found to make it work is not the one in the README, but this one:

  unit_localization(:person, "ja", :long,
    nominative: %{
      one: "{0} 人",
      other: "{0} 人"
    },
    display_name: "人"
  )

Can you confirm that's correct? if so I can update it.

kipcole9 commented 1 year ago

You are correct, the README.md needs updating (the changelog entry for ex_cldr_units 3.5.0 has the up-to-date information.

A PR would be very welcome.

ribanez7 commented 1 year ago

Closing!