elixir-cloud-aai / TESK

GA4GH Task Execution Service Root Project + Deployment scripts on Kubernetes
https://tesk.readthedocs.io
Apache License 2.0
39 stars 29 forks source link

feat: add service info endpoint #198

Closed JaeAeich closed 2 months ago

JaeAeich commented 3 months ago

Summary by Sourcery

This pull request adds a new service info endpoint to the TES API, allowing clients to retrieve metadata about the service. It includes updates to the deployment configuration to support this new endpoint.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request introduces a new endpoint to provide service information for the TES API. The changes include adding custom configuration in the deployment config file, implementing a new ServiceInfo class to handle service info, modifying the controller to use this new class, and updating the Service model to change the type of the contactUrl field.

File-Level Changes

Files Changes
tesk/api/ga4gh/tes/service_info/service_info.py
tesk/api/ga4gh/tes/service_info/__init__.py
Added new module for handling TES Service Info, including a class with methods to fetch and serialize service info.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.21%. Comparing base (e790298) to head (ccc9726).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ======================================= Coverage 98.21% 98.21% ======================================= Files 8 8 Lines 561 561 ======================================= Hits 551 551 Misses 10 10 ``` | [Flag](https://app.codecov.io/gh/elixir-cloud-aai/TESK/pull/198/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | Coverage Δ | | |---|---|---| | [test_unit](https://app.codecov.io/gh/elixir-cloud-aai/TESK/pull/198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai) | `98.21% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elixir-cloud-aai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JaeAeich commented 2 months ago

@uniqueg I updated the branch and ig the safety DB has recently found new vulnerebilities, so had to add them and someof their fixes in this PR as well otherwise we woudn't have been able to merge.

JaeAeich commented 2 months ago

This looks good to me. Please resolve the open convos and then we are ready to go 🚀

all convos are resolved!