search

elixir-cloud-aai / cloud-components

Reusable components for the ELIXIR Cloud
https://cloud-components.2.rahtiapp.fi/
Apache License 2.0
8 stars 15 forks source link

feat: add API to fields configs #253

Closed JaeAeich closed 4 months ago

JaeAeich commented 8 months ago

Description

In the current behaviour, when the fields is passed it replaces the previous set configuration of fields (structural design of runs components). Since there will be multiple implementation of WES and TES which might not be compliant, it might be a good idea to give the feature of extending default config rather than always replacing it.

Possible solution(s)

Add extends API(prop) to ecc-client-litga4gh-tes-runs and ecc-client-lit-ga4gh-wes-runs, and now when the app-author passes extends=true the fields passes should extend the default fields/config.

uniqueg commented 8 months ago

If I understand this correctly, this makes sense even for compliant implementations, because the GA4GH API specs generally do not prohibit additional properties in their models.