Closed SalihuDickson closed 3 weeks ago
Latest commit: d18c7c0ab9a706e096e8e94aeaea209679c1f83a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
elixir-cloud-components | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 4, 2024 10:51pm |
This PR implements readonly functionality for form fields and improves tooltip handling. The changes primarily focus on adding a readonly option to various form field types and refactoring tooltip checks to use trim(). Additionally, new input height variables have been introduced for larger form elements.
classDiagram
class EccUtilsDesignForm {
+Field[] fields
+render()
+handleTusFileUpload(Event, Field)
}
class Field {
+String key
+String label
+FieldOptions fieldOptions
+FileOptions fileOptions
+String type
}
class FieldOptions {
+String accept
+Boolean returnIfEmpty
+String tooltip
+Boolean readonly
+Boolean required
+Boolean multiple
}
class FileOptions {
+String protocol
}
EccUtilsDesignForm --> Field
Field --> FieldOptions
Field --> FileOptions
note for FieldOptions "Added readonly attribute"
Change | Details | Files |
---|---|---|
Added readonly field support to form components |
|
packages/ecc-utils-design/src/components/form/form.ts |
Improved tooltip handling in form components |
|
packages/ecc-utils-design/src/components/form/form.ts |
Enhanced styling system with new height variables |
|
packages/ecc-utils-design/src/styles/primitive.styles.ts packages/ecc-utils-design/src/components/form/form.styles.ts |
Issue | Objective | Addressed | Explanation |
---|---|---|---|
#376 | Add support for readonly input fields in the form component | ✅ |
sure @anuragxxd, i'll add the feature to the docs.
@sivangbagri, when this get's merged please add create a PR to add a single type field back the dataset entity, and it should be a readonly field.
@anuragxxd, issues have been resolved, please review.
Description
Fixes #376
Checklist
Comments
Summary by Sourcery
Add a 'readonly' option to form fields to allow them to be disabled, and enhance tooltip handling by trimming whitespace.
New Features:
Enhancements: