fix: add dynamic min height for group components

SalihuDickson commented 4 weeks ago

Description

Fixes #377

Checklist

[ ] My code follows the contributing guidelines of this project.
[ ] I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code in hard-to-understand areas.
[ ] I have updated the user-facing documentation to describe any new or changed behavior.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have not reduced the existing code coverage.

Comments

Summary by Sourcery

Bug Fixes:

Add dynamic minimum height for group components to ensure consistent layout.

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 2bce16b7caf2a411276919b13c546809a284b4cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | -------------------- | ----- | | @elixir-cloud/design | Patch | | @elixir-cloud/tes | Patch | | @elixir-cloud/wes | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
elixir-cloud-components	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 3, 2024 8:56pm

sourcery-ai[bot] commented 4 weeks ago

Reviewer's Guide by Sourcery

This PR implements a dynamic minimum height for group components by adding new CSS variables for larger input heights and applying them to group items. The changes are made through CSS modifications in the design system's form and primitive style files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added new CSS variables for extra-large input heights	Introduced three new height variables: xlarge, 2xlarge, and 3xlarge Variables are calculated based on the existing sizing internal variable	`packages/ecc-utils-design/src/styles/primitive.styles.ts`
Applied minimum height to group items in forms	Added min-height property to group-item class using the new 3xlarge input height variable	`packages/ecc-utils-design/src/components/form/form.styles.ts`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#377	Fix the height of group components to properly display select field options without distortion	✅

Possibly linked issues

#377: The PR adds dynamic min height to fix the group component height issue for select fields.

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

SalihuDickson commented 3 weeks ago

@anuragxxd, I've added the changeset, please review.

anuragxxd commented 3 weeks ago

Hey @SalihuDickson, I can now only see the change-log & no other changes. What can be the case? Are you sure no changes are being missed due to the merge conflicts or git?

SalihuDickson commented 3 weeks ago

yh, it seems i might have accidentally effected the same changes the other PR i merged, so pulling the changes from main made this PR effectively useless. I'll go ahead and close it.

elixir-cloud-aai / cloud-components