elixir-cloud-aai / cloud-registry

GA4GH Service Registry API implementation for the ELIXIR Cloud
Apache License 2.0
4 stars 1 forks source link

build: upgrade FOCA & fix ReadTheDocs #38

Closed alohamora closed 1 year ago

alohamora commented 1 year ago

Description

  1. Upgrade foca to the latest version (0.12.1). This change introduces no updates in config/functionality as the foca upgrade doesn't introduce any breaking changes.
  2. fix readthedocs build failure by adding documentation build config and requirements

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (8ac2118) 100.00% compared to head (2817aa9) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #38 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 6 6 Lines 190 190 ========================================= Hits 190 190 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alohamora commented 1 year ago

@uniqueg the RtD ci step still failed, as per the error, it is trying to find a file named .readthedocs.yaml for it's configuration which does not exist in our repo

alohamora commented 1 year ago

finally, all test passed 😛 had to add additional requirements for building documentation with the sphinx_rtd_theme as now readthedocs does not download this theme package by default.

alohamora commented 1 year ago

@uniqueg can you please review this PR