elixir-cloud-aai / cwl-WES

Trigger CWL workflows via GA4GH WES and TES
Apache License 2.0
16 stars 18 forks source link

fix: update cwl-tes log parsing #209

Closed zagganas closed 3 years ago

zagganas commented 3 years ago

Details

This pull request resolves the output parsing from the cwl-TES logs that used regexp and made cwl-WES hang (Issue #208). Instead, the logs are parsed in reverse order, since cwl-TES logs a JSON containing the outputs and links to them before completing. It is easy, thus, to discover this JSON and provide it to cwl-WES instead of using regular expressions.

Testing

Tested for workflows with and without outputs and it works as expected.

Documentation

Changed cwl_wes/tasks/celery_monitor.py. Added a new function and call to that function, but left the old call commented and also the old function.

Closing issues

Closes #208.

Credit

Kostis Zagganas