Closed manabuishii closed 3 years ago
Thanks @manabuishii - looks good, but no cloue why the build fails. The logs don't show any errors. I'll just rerun and try again
Further testing showed that cwl-WES does send Access-Control-Allow-Origin: *
header when it accepts a correct POST request. When a wrong request comes, it raises an error and returns a 400 bad request without the header. It's confusing, but I assume we need to fix the flask app to add the header even when the error was raised during the routing process, which may be tricky.
Manabu's comment shows that it returns 404 not found after the change was introduced, it should have caused another problem. I assume the test failure is somehow related to it.
I suggest to close this PR, but if one wants to avoid the confusing browser message, I won't stop :)
Details
ADD CORS Header for POST /runs
Testing
Sorry no test code but tested on my console
Before fix
After
Documentation
GET method already have CORS header. but POST method do not have CORS header
Style
...
Closing issues
...
Credit
...