search

elixir-cloud-aai / cwl-WES

Trigger CWL workflows via GA4GH WES and TES
Apache License 2.0
16 stars 18 forks source link

Add configuration of mongodb and rabbotmq hosts #255

Closed lvarin closed 3 months ago

lvarin commented 3 months ago

IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.

Details

Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with #XXXX for more information.

Testing

Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.

Documentation

Please document your changes and test cases in the appropriate places, if applicable.

Style

Make sure your changes adhere to the coding/documentation style used throughout the project.

Closing issues

If your changes fix any issue/s, put closes #XXXX in your comment to auto-close it/them.

Credit

Add your credentials to the list of contributors once your pull request was merged.

Summary by Sourcery

Added configuration options for MongoDB and RabbitMQ hosts in the update-config-map.sh script. Default values are set to 'mongodb' and 'rabbitmq' respectively if not provided.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request adds the configuration of MongoDB and RabbitMQ hosts to the update-config-map.sh script. The changes ensure that the script can dynamically set the MongoDB and RabbitMQ hosts based on environment variables, with default values if the variables are not set.

File-Level Changes

Files Changes
update-config-map.sh Added dynamic configuration for MongoDB and RabbitMQ hosts using environment variables and updated the script to reflect these changes.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.