feat: add "DELETE ../access_method/{access_id}"

elixir-cloud-aai / drs-filer

Lightweight, flexible Flask/Gunicorn-based GA4GH DRS implementation

Apache License 2.0

5 stars 8 forks source link

feat: add "DELETE ../access_method/{access_id}" #30

Closed chinvib66 closed 3 years ago

chinvib66 commented 3 years ago

Description

add specs for DELETE /objects/{object_id}/access/{access_id} endpoint
implement endpoint logic and tests

Resolves #27

chinvib66 commented 3 years ago

@uniqueg PR ready for review

uniqueg commented 3 years ago

This looks really nice @chinvib66! Will have a detailed look and a manual integration test later on tonight or latest tomorrow and add the test for the missing line (unless you wanna do it yourself). But thanks a lot already 🙏🏻

chinvib66 commented 3 years ago

@uniqueg I couldn't figure out how to cover that line.

It's for internal server error if db update_one fails for some reason. Line 147

uniqueg commented 3 years ago

Ah, thanks, @chinvib66, saves me some time checking this. Guess the way is to mock up the response of update_one(). I'll figure it out! If you are interested in these kind of things (healthcare-related interoperable API microservices), let me know - I think we got a pretty interesting project going on. If you like, you can check those slides for details: https://docs.google.com/presentation/d/1y-dYxz0aZ1TnASQzT2wZ99agTY2z6jaixZG4ZNQ-zFg/