Closed jvkersch closed 2 months ago
This pull request updates the FOCA library to version 0.13.0. The primary change involves updating the way the FOCA configuration is accessed within the application code and tests. Specifically, the configuration is now accessed using app.config.foca
instead of app.config['FOCA']
. This update addresses issue #49 and ensures compatibility with the latest version of FOCA.
Files | Changes |
---|---|
tests/ga4gh/drs/test_server.py tests/ga4gh/drs/endpoints/test_service_info.py tests/ga4gh/drs/endpoints/test_register_objects.py |
Updated FOCA configuration access in multiple test files to use app.config.foca instead of app.config['FOCA'] . |
drs_filer/ga4gh/drs/endpoints/register_objects.py drs_filer/ga4gh/drs/server.py drs_filer/ga4gh/drs/endpoints/service_info.py |
Updated FOCA configuration access in multiple endpoint and server files to use current_app.config.foca instead of current_app.config['FOCA'] . |
Thanks @kushagra189, I've done that particular refactor in the module where there were a lot of repeated usages of that object. There was another instance where Sourcery suggested a refactor but that was not applicable (the repeated code was spread out over multiple functions).
The only open issue is the use of eval
(#54). I would suggest merging this PR as-is and tackling that issue separately.
Description
Updates FOCA to the latest version, which is 0.13.0 at the time this PR was opened.
Fixes #49
Type of change
Please delete options that are not relevant.
Checklist:
Summary by Sourcery
This pull request updates the FOCA library to version 0.13.0, refactors the code to use the new configuration syntax, and adjusts the test cases accordingly to ensure compatibility and functionality.