feat: clarify error

[uniqueg]

Description

Change error response from 400 to 409 and return an informative error message if the client attempts to delete the last remaining access method of an object. The OpenAPI specfication was updated accordingly.

Fixes #53

Type of change

• [x] New feature (non-breaking change which adds functionality)

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] I have not reduced the existing code coverage
• [x] I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
• [x] I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request introduces a new exception AccessMethodNotDeleted to handle cases where the last remaining access method of an object is attempted to be deleted. The DeleteAccessMethod function and related tests have been updated accordingly. Additionally, the API documentation has been updated to reflect the new 409 error response.

• New Features:
  • Introduced a new exception AccessMethodNotDeleted to handle cases where the last remaining access method of an object is attempted to be deleted.
• Enhancements:
  • Updated the DeleteAccessMethod function to raise AccessMethodNotDeleted instead of BadRequest when attempting to delete the last remaining access method.
• Documentation:
  • Updated the API documentation to include the new 409 error response for refusing to delete the last remaining access method.
• Tests:
  • Renamed and updated the test case to check for AccessMethodNotDeleted exception instead of BadRequest when deleting the last remaining access method.

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request introduces a new custom exception AccessMethodNotDeleted to handle cases where an attempt is made to delete the last remaining access method of an object. The changes include updates to exception handling, API documentation, and unit tests to reflect this new exception.

File-Level Changes

Files	Changes
drs_filer/errors/exceptions.py drs_filer/ga4gh/drs/server.py drs_filer/api/additional.data_repository_service.swagger.yaml tests/ga4gh/drs/test_server.py	Introduced a new exception AccessMethodNotDeleted to handle cases where the last remaining access method of an object is attempted to be deleted. Updated the server logic, API documentation, and unit tests to reflect this new exception.

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.