elixir-cloud-aai / drs-filer

Lightweight, flexible Flask/Gunicorn-based GA4GH DRS implementation
Apache License 2.0
5 stars 8 forks source link

Allow changing mongodb URL #63

Closed lvarin closed 1 month ago

lvarin commented 1 month ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

Summary by Sourcery

This pull request adds the capability to change the MongoDB host URL through an environment variable, updates the configuration script to reflect this change, and modifies the deployment template to set the MongoDB host for the DRS Filer ConfigMap job.

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request introduces a new feature that allows the MongoDB URL to be configured via an environment variable. The changes include updates to the update-config-map.sh script to check for and use the MONGO_HOST environment variable, and modifications to the drs-filer-configmap-job.yaml template to set this variable. This enhancement ensures that the MongoDB host can be dynamically set, improving the flexibility of the deployment configuration.

File-Level Changes

Files Changes
update-config-map.sh
deployment/templates/drs-filer-configmap-job.yaml
Introduced the ability to configure the MongoDB host via an environment variable, ensuring the MongoDB URL can be dynamically set.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.