build: limit supported Connexion versions

alohamora commented 1 year ago

Description

This PR adds the following changes

upper limit for connexion requirement set as (3.0.0) i.e connexion dependency now has the following version specifier connexion>=2.11.2,<3.0.0. This change is added because foca is not compatible with the new major version release of connexion, and until that is fixed, we need to limit the requirement specifier for foca as all other PR builds are failing.

The failure screenshot with the latest version of connexion

[2023-11-30 16:56:26,255: INFO    ] Log formatting configured. [foca.foca]
[2023-11-30 16:56:26,255: INFO    ] Configuration file 'config.yaml' parsed. [foca.foca]
Traceback (most recent call last):
  File "app.py", line 25, in <module>
    main()
  File "app.py", line 13, in main
    app = foca.create_app()
  File "/Users/adityaarora/opt/miniforge3/envs/cloud-registry/lib/python3.8/site-packages/foca/foca.py", line 94, in create_app
    cnx_app = create_connexion_app(self.conf)
  File "/Users/adityaarora/opt/miniforge3/envs/cloud-registry/lib/python3.8/site-packages/foca/factories/connexion_app.py", line 25, in create_connexion_app
    app = App(
TypeError: __init__() got an unexpected keyword argument 'skip_error_handlers'

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the documentation (or documentation does not need to be updated)
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have not reduced the existing code coverage

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d4c1280) 100.00% compared to head (4bc0518) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #185 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 978 978 ========================================= Hits 978 978 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alohamora commented 1 year ago

sure, I have separated out the documentation changes in the following PR - https://github.com/elixir-cloud-aai/foca/pull/186 Please note it would fail checks due to connexion changes not being present. I had merged the changes into one PR because we needed both the changes to pass the build checks

elixir-cloud-aai / foca