Closed Rahuljagwani closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2c89ba8
) 100.00% compared to head (61d754a
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am not able to get it. When I pushed the commit, the pet store tests failed as one of the statements was DOCKERHUB_ORG:
. But in other PR tests, the same statement comes as: DOCKERHUB_ORG: ***
. Link.
Am I doing something wrong?
@uniqueg
You still created the pull request from your fork.
Instead, what you should do is:
git clone https://github.com/elixir-cloud-aai/foca.git
cd foca
git checkout -b "pep561"
git add setup.py py.typed
git commit -m "build: make project PEP 561 compliant"
git push origin pep561
You still created the pull request from your fork.
Instead, what you should do is:
- Clone the repo and move inside the directory:
git clone https://github.com/elixir-cloud-aai/foca.git cd foca
- Then create a "feature branch" with:
git checkout -b "pep561"
- Apply your changes.
- Stage files, commit and push:
git add setup.py py.typed git commit -m "build: make project PEP 561 compliant" git push origin pep561
- Finally, come back to the repo and create a new pull request.
Thanks a lot @uniqueg, created PR #193 (finally all checks have passed).
Do we need to mention the above steps in developer documentation orCONTRIBUTING.md
for new contributors?
Description
Fixes #187
Type of change
Checklist: