elixir-cloud-aai / ga4gh-sdk

Generic SDK and CLI for GA4GH API services
Apache License 2.0
13 stars 2 forks source link

feat: add configuration & transport structs #30

Closed aaravm closed 3 months ago

aaravm commented 4 months ago

This pull request introduces two new structs: Configuration for storing API request details and Transport for making HTTP requests using the reqwest library. It also includes unit tests for the Transport struct.

Summary by Sourcery

This pull request introduces two new structs: Configuration for storing API request details and Transport for making HTTP requests using the reqwest library. It also includes unit tests for the Transport struct.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces two new structs: Configuration for storing API request details and Transport for making HTTP requests using the reqwest library. The Transport struct includes methods for GET, POST, PUT, and DELETE requests, and is tested using the mockito library. The Configuration struct handles base path, user agent, and various authentication methods.

File-Level Changes

Files Changes
lib/src/transport.rs
lib/src/configuration.rs
Introduced Configuration and Transport structs to manage API request details and HTTP requests, respectively. Added unit tests for Transport.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
aaravm commented 3 months ago

@uniqueg, I think this PR can be merged now. Please mention if you think any other change should be made..

aaravm commented 3 months ago

I have merged this PR, as it doesn't really depend on any other PR, and will be moving these structs to utils folder to utils in #35